Commit 44a09e3d authored by Nicholas Kazlauskas's avatar Nicholas Kazlauskas Committed by Alex Deucher
Browse files

drm/amd/display: Guard against NULL pointer deref when get_i2c_info fails 



[Why]
If the BIOS table is invalid or corrupt then get_i2c_info can fail
and we dereference a NULL pointer.

[How]
Check that ddc_pin is not NULL before using it and log an error if it
is because this is unexpected.

Tested-by: default avatarDaniel Wheeler <daniel.wheeler@amd.com>
Signed-off-by: default avatarNicholas Kazlauskas <nicholas.kazlauskas@amd.com>
Reviewed-by: default avatarEric Yang <eric.yang2@amd.com>
Acked-by: default avatarAnson Jacob <anson.jacob@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent eee96474

drivers/gpu/drm/amd/display/dc/core/dc_link.c

+5 −0
Original line number Diff line number Diff line
@@ -1481,6 +1481,11 @@ static bool dc_link_construct(struct dc_link *link, 
		goto ddc_create_fail;

	}



	if (!link->ddc->ddc_pin) {

		DC_ERROR("Failed to get I2C info for connector!\n");

		goto ddc_create_fail;

	}



	link->ddc_hw_inst =

		dal_ddc_get_line(dal_ddc_service_get_ddc_pin(link->ddc));