Commit 448cf905 authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Bartosz Golaszewski
Browse files

gpio: Get rid of duplicate of_node assignment in the drivers 



GPIO library does copy the of_node from the parent device of
the GPIO chip, there is no need to repeat this in the individual
drivers. Remove these assignment all at once.

For the details one may look into the of_gpio_dev_init() implementation.

While at it, remove duplicate parent device assignment where it is the case.

Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-By: default avatarMatti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Signed-off-by: default avatarBartosz Golaszewski <brgl@bgdev.pl>
parent ca7e7822

drivers/gpio/gpio-adnp.c

+0 −1
Original line number Diff line number Diff line
@@ -458,7 +458,6 @@ static int adnp_gpio_setup(struct adnp *adnp, unsigned int num_gpios, 
	chip->ngpio = num_gpios;

	chip->label = adnp->client->name;

	chip->parent = &adnp->client->dev;

	chip->of_node = chip->parent->of_node;

	chip->owner = THIS_MODULE;



	if (is_irq_controller) {

drivers/gpio/gpio-amdpt.c

+1 −3
Original line number Diff line number Diff line
@@ -105,9 +105,7 @@ static int pt_gpio_probe(struct platform_device *pdev) 
	pt_gpio->gc.request          = pt_gpio_request;

	pt_gpio->gc.free             = pt_gpio_free;

	pt_gpio->gc.ngpio            = (uintptr_t)device_get_match_data(dev);

#if defined(CONFIG_OF_GPIO)

	pt_gpio->gc.of_node          = dev->of_node;

#endif



	ret = gpiochip_add_data(&pt_gpio->gc, pt_gpio);

	if (ret) {

		dev_err(dev, "Failed to register GPIO lib\n");

drivers/gpio/gpio-bd71828.c

+0 −1
Original line number Diff line number Diff line
@@ -121,7 +121,6 @@ static int bd71828_probe(struct platform_device *pdev) 
	 * "gpio-reserved-ranges" and exclude them from control

	 */

	bdgpio->gpio.ngpio = 4;

	bdgpio->gpio.of_node = dev->parent->of_node;

	bdgpio->regmap = dev_get_regmap(dev->parent, NULL);

	if (!bdgpio->regmap)

		return -ENODEV;

drivers/gpio/gpio-brcmstb.c

+0 −1
Original line number Diff line number Diff line
@@ -703,7 +703,6 @@ static int brcmstb_gpio_probe(struct platform_device *pdev) 
			goto fail;

		}



		gc->of_node = np;

		gc->owner = THIS_MODULE;

		gc->label = devm_kasprintf(dev, GFP_KERNEL, "%pOF", dev->of_node);

		if (!gc->label) {

drivers/gpio/gpio-davinci.c

+0 −1
Original line number Diff line number Diff line
@@ -254,7 +254,6 @@ static int davinci_gpio_probe(struct platform_device *pdev) 
#ifdef CONFIG_OF_GPIO

	chips->chip.of_gpio_n_cells = 2;

	chips->chip.parent = dev;

	chips->chip.of_node = dev->of_node;

	chips->chip.request = gpiochip_generic_request;

	chips->chip.free = gpiochip_generic_free;

#endif