Commit 4481bdc6 authored by John Garry's avatar John Garry Committed by Martin K. Petersen
Browse files

scsi: pm8001: Drop !task check in pm8001_abort_task() 



In commit 0b639dec ("scsi: pm8001: Modify task abort handling for SATA
task"), code was introduced to dereference "task" pointer in
pm8001_abort_task(). However there was a pre-existing later check for
"!task", which spooked the kernel test robot.

Function pm8001_abort_task() should never be passed NULL for "task"
pointer, so remove that check. Also remove the "unlikely" hint, as this is
not fastpath code.

Reported-by: default avatarkernel test robot <lkp@intel.com>
Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarJohn Garry <john.garry@huawei.com>
Link: https://lore.kernel.org/r/1666781764-123090-1-git-send-email-john.garry@huawei.com


Reviewed-by: default avatarDamien Le Moal <damien.lemoal@opensource.wdc.com>
Acked-by: default avatarJack Wang <jinpu.wang@ionos.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 9d266e79

drivers/scsi/pm8001/pm8001_sas.c

+1 −1
Original line number Diff line number Diff line
@@ -979,7 +979,7 @@ int pm8001_abort_task(struct sas_task *task) 
	u32 phy_id, port_id;

	struct sas_task_slow slow_task;



	if (unlikely(!task || !task->lldd_task || !task->dev))

	if (!task->lldd_task || !task->dev)

		return TMF_RESP_FUNC_FAILED;



	dev = task->dev;