Commit 447b437f authored by Dafna Hirschfeld's avatar Dafna Hirschfeld Committed by Mauro Carvalho Chehab
Browse files

media: stk1160: fix number of buffers in case not all buffers are created 



In case we fail to allocate a transfer_buffer then we
break the buffers creation loop and update the number of
buffers to the number of successfully allocated which should
be 'i' and not 'i - 1' nor 'i + 1'

Signed-off-by: default avatarDafna Hirschfeld <dafna.hirschfeld@collabora.com>
Reviewed-by: default avatarEzequiel Garcia <ezequiel@vanguardiasur.com.ar>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@kernel.org>
parent cf1abc50

drivers/media/usb/stk1160/stk1160-video.c

+3 −3
Original line number Diff line number Diff line
@@ -511,15 +511,15 @@ int stk1160_alloc_isoc(struct stk1160 *dev) 
	usb_free_urb(dev->isoc_ctl.urb[i]);

	dev->isoc_ctl.urb[i] = NULL;



	stk1160_warn("%d urbs allocated. Trying to continue...\n", i - 1);

	stk1160_warn("%d urbs allocated. Trying to continue...\n", i);



	dev->isoc_ctl.num_bufs = i - 1;

	dev->isoc_ctl.num_bufs = i;



	return 0;



free_i_bufs:

	/* Save the allocated buffers so far, so we can properly free them */

	dev->isoc_ctl.num_bufs = i+1;

	dev->isoc_ctl.num_bufs = i;

	stk1160_free_isoc(dev);

	return -ENOMEM;

}