Commit 446cd6f0 authored by Tian Tao's avatar Tian Tao Committed by Jarkko Sakkinen
Browse files

char: tpm: move to use request_irq by IRQF_NO_AUTOEN flag 

disable_irq() after request_irq() still has a time gap in which
interrupts can come. request_irq() with IRQF_NO_AUTOEN flag will
disable IRQ auto-enable because of requesting.

Link: https://lore.kernel.org/patchwork/patch/1388765/


Signed-off-by: default avatarTian Tao <tiantao6@hisilicon.com>
Reviewed-by: default avatarJarkko Sakkinen <jarkko@kernel.org>
Signed-off-by: default avatarJarkko Sakkinen <jarkko@kernel.org>
parent 114e4337

drivers/char/tpm/tpm_tis_i2c_cr50.c

+2 −2
Original line number Diff line number Diff line
@@ -706,14 +706,14 @@ static int tpm_cr50_i2c_probe(struct i2c_client *client, 


	if (client->irq > 0) {

		rc = devm_request_irq(dev, client->irq, tpm_cr50_i2c_int_handler,

				      IRQF_TRIGGER_FALLING | IRQF_ONESHOT,

				      IRQF_TRIGGER_FALLING | IRQF_ONESHOT |

				      IRQF_NO_AUTOEN,

				      dev->driver->name, chip);

		if (rc < 0) {

			dev_err(dev, "Failed to probe IRQ %d\n", client->irq);

			return rc;

		}



		disable_irq(client->irq);

		priv->irq = client->irq;

	} else {

		dev_warn(dev, "No IRQ, will use %ums delay for TPM ready\n",