Commit 444ff007 authored by Hans de Goede's avatar Hans de Goede Committed by Sebastian Reichel
Browse files

power: supply: bq27xxx: Fix I2C IRQ race on remove 



devm_request_threaded_irq() requested IRQs are only free-ed after
the driver's remove function has ran. So the IRQ could trigger and
call bq27xxx_battery_update() after bq27xxx_battery_teardown() has
already run.

Switch to explicitly free-ing the IRQ in bq27xxx_battery_i2c_remove()
to fix this.

Fixes: 8807feb9 ("power: bq27xxx_battery: Add interrupt handling support")
Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
Signed-off-by: default avatarSebastian Reichel <sebastian.reichel@collabora.com>
parent 5c34c0ae

drivers/power/supply/bq27xxx_battery_i2c.c

+2 −1
Original line number Diff line number Diff line
@@ -179,7 +179,7 @@ static int bq27xxx_battery_i2c_probe(struct i2c_client *client) 
	i2c_set_clientdata(client, di);



	if (client->irq) {

		ret = devm_request_threaded_irq(&client->dev, client->irq,

		ret = request_threaded_irq(client->irq,

				NULL, bq27xxx_battery_irq_handler_thread,

				IRQF_ONESHOT,

				di->name, di);
@@ -209,6 +209,7 @@ static void bq27xxx_battery_i2c_remove(struct i2c_client *client) 
{

	struct bq27xxx_device_info *di = i2c_get_clientdata(client);



	free_irq(client->irq, di);

	bq27xxx_battery_teardown(di);



	mutex_lock(&battery_mutex);