Commit 4424c35e authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Miguel Ojeda
Browse files

auxdisplay: lcd2s: Fix lcd2s_redefine_char() feature 



It seems that the lcd2s_redefine_char() has never been properly
tested. The buffer is filled by DEF_CUSTOM_CHAR command followed
by the character number (from 0 to 7), but immediately after that
these bytes are rewritten by the decoded hex stream.

Fix the index to fill the buffer after the command and number.

Fixes: 8c9108d0 ("auxdisplay: add a driver for lcd2s character display")
Cc: Lars Poeschel <poeschel@lemonage.de>
Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: default avatarGeert Uytterhoeven <geert@linux-m68k.org>
[fixed typo in commit message]
Signed-off-by: default avatarMiguel Ojeda <ojeda@kernel.org>
parent 7e57714c

drivers/auxdisplay/lcd2s.c

+1 −1
Original line number Diff line number Diff line
@@ -238,7 +238,7 @@ static int lcd2s_redefine_char(struct charlcd *lcd, char *esc) 
	if (buf[1] > 7)

		return 1;



	i = 0;

	i = 2;

	shift = 0;

	value = 0;

	while (*esc && i < LCD2S_CHARACTER_SIZE + 2) {