Commit 441c9381 authored by Jiri Slaby (SUSE)'s avatar Jiri Slaby (SUSE) Committed by Greg Kroah-Hartman
Browse files

tty: vt: replace BUG_ON() by WARN_ON_ONCE() 



No need to panic in vc_uniscr_copy_line(), just warn. This should never
happen though, as vc_uniscr_check() is supposed to be called before
vc_uniscr_copy_line(). And the former checks vc->vc_uni_lines already.

In any case, use _ONCE as vc_uniscr_copy_line() is called repeatedly for
each line. So don't flood the logs, just in case.

Signed-off-by: default avatarJiri Slaby (SUSE) <jirislaby@kernel.org>
Reviewed-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Link: https://lore.kernel.org/r/20230112080136.4929-7-jirislaby@kernel.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent feb36abb

drivers/tty/vt/vt.c

+2 −1
Original line number Diff line number Diff line
@@ -535,7 +535,8 @@ void vc_uniscr_copy_line(const struct vc_data *vc, void *dest, bool viewed, 
	int offset = row * vc->vc_size_row + col * 2;

	unsigned long pos;



	BUG_ON(!uni_lines);

	if (WARN_ON_ONCE(!uni_lines))

		return;



	pos = (unsigned long)screenpos(vc, offset, viewed);

	if (pos >= vc->vc_origin && pos < vc->vc_scr_end) {