Commit 43fb622d authored by Russell King (Oracle)'s avatar Russell King (Oracle) Committed by David S. Miller
Browse files

net: pcs: xpcs: fix incorrect number of interfaces 



In synopsys_xpcs_compat[], the DW_XPCS_2500BASEX entry was setting
the number of interfaces using the xpcs_2500basex_features array
rather than xpcs_2500basex_interfaces. This causes us to overflow
the array of interfaces. Fix this.

Fixes: f27abde3 ("net: pcs: add 2500BASEX support for Intel mGbE controller")
Signed-off-by: default avatarRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Reviewed-by: default avatarLeon Romanovsky <leonro@nvidia.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent d0ac89f6

drivers/net/pcs/pcs-xpcs.c

+1 −1
Original line number Diff line number Diff line
@@ -1203,7 +1203,7 @@ static const struct xpcs_compat synopsys_xpcs_compat[DW_XPCS_INTERFACE_MAX] = { 
	[DW_XPCS_2500BASEX] = {

		.supported = xpcs_2500basex_features,

		.interface = xpcs_2500basex_interfaces,

		.num_interfaces = ARRAY_SIZE(xpcs_2500basex_features),

		.num_interfaces = ARRAY_SIZE(xpcs_2500basex_interfaces),

		.an_mode = DW_2500BASEX,

	},

};