Commit 43d25378 authored by Randy Dunlap's avatar Randy Dunlap Committed by David S. Miller
Browse files

net: sched: htb: fix htb_classify() kernel-doc 



Fix W=1 kernel-doc warning:

net/sched/sch_htb.c:214: warning: expecting prototype for htb_classify(). Prototype was for HTB_DIRECT() instead

by moving the HTB_DIRECT() macro above the function.
Add kernel-doc notation for function parameters as well.

Signed-off-by: default avatarRandy Dunlap <rdunlap@infradead.org>
Cc: Jamal Hadi Salim <jhs@mojatatu.com>
Cc: Cong Wang <xiyou.wangcong@gmail.com>
Cc: Jiri Pirko <jiri@resnulli.us>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Eric Dumazet <edumazet@google.com>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 819fcf4a

net/sched/sch_htb.c

+6 −2
Original line number Diff line number Diff line
@@ -199,8 +199,14 @@ static unsigned long htb_search(struct Qdisc *sch, u32 handle) 
{

	return (unsigned long)htb_find(handle, sch);

}



#define HTB_DIRECT ((struct htb_class *)-1L)



/**

 * htb_classify - classify a packet into class

 * @skb: the socket buffer

 * @sch: the active queue discipline

 * @qerr: pointer for returned status code

 *

 * It returns NULL if the packet should be dropped or -1 if the packet

 * should be passed directly thru. In all other cases leaf class is returned.
@@ -211,8 +217,6 @@ static unsigned long htb_search(struct Qdisc *sch, u32 handle) 
 * have no valid leaf we try to use MAJOR:default leaf. It still unsuccessful

 * then finish and return direct queue.

 */

#define HTB_DIRECT ((struct htb_class *)-1L)



static struct htb_class *htb_classify(struct sk_buff *skb, struct Qdisc *sch,

				      int *qerr)

{