Commit 43c73ca4 authored by Jonathan Brassow's avatar Jonathan Brassow Committed by NeilBrown
Browse files

md/raid5: use sysfs_notify_dirent_safe to avoid NULL pointer 



With the module parameter 'start_dirty_degraded' set,
raid5_spare_active() previously called sysfs_notify_dirent() with a NULL
argument (rdev->sysfs_state) when a rebuild finished.

Signed-off-by: default avatarJonathan Brassow <jbrassow@redhat.com>
Signed-off-by: default avatarMike Snitzer <snitzer@redhat.com>
parent 0ca69886

drivers/md/raid5.c

+1 −1
Original line number Diff line number Diff line
@@ -5338,7 +5338,7 @@ static int raid5_spare_active(mddev_t *mddev) 
		    && !test_bit(Faulty, &tmp->rdev->flags)

		    && !test_and_set_bit(In_sync, &tmp->rdev->flags)) {

			count++;

			sysfs_notify_dirent(tmp->rdev->sysfs_state);

			sysfs_notify_dirent_safe(tmp->rdev->sysfs_state);

		}

	}

	spin_lock_irqsave(&conf->device_lock, flags);