Commit 43b2aef3 authored by Steven Rostedt (Google)'s avatar Steven Rostedt (Google)
Browse files

neighbor: tracing: Have neigh_create event use __string()

The dev field of the neigh_create event uses __dynamic_array() with a
fixed size, which defeats the purpose of __dynamic_array(). Looking at the
logic, as it already uses __assign_str(), just use the same logic in
__string to create the size needed. It appears that because "dev" can be
NULL, it needs the check. But __string() can have the same checks as
__assign_str() so use them there too.

Link: https://lkml.kernel.org/r/20220705183741.35387e3f@rorschach.local.home



Cc: David Ahern <dsahern@gmail.com>
Cc: David S. Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Acked-by: default avatarJakub Kicinski <kuba@kernel.org>
Reviewed-by: default avatarDavid Ahern <dsahern@kernel.org>
Signed-off-by: default avatarSteven Rostedt (Google) <rostedt@goodmis.org>
parent fca8300f
Loading
Loading
Loading
Loading
+1 −1
Original line number Original line Diff line number Diff line
@@ -30,7 +30,7 @@ TRACE_EVENT(neigh_create,


	TP_STRUCT__entry(
	TP_STRUCT__entry(
		__field(u32, family)
		__field(u32, family)
		__dynamic_array(char,  dev,   IFNAMSIZ )
		__string(dev, dev ? dev->name : "NULL")
		__field(int, entries)
		__field(int, entries)
		__field(u8, created)
		__field(u8, created)
		__field(u8, gc_exempt)
		__field(u8, gc_exempt)