Commit 43aa323e authored by Alexander Usyskin's avatar Alexander Usyskin Committed by Greg Kroah-Hartman
Browse files

mei: cleanup status before client dma setup call 



The upper layer may retry call to mei_cl_dma_alloc_and_map(),
in that case the client status may be non-zero after the previous call
and the wait condition will be true immediately.
Set cl->status to zero to allow waiting for an actual result
from the firmware.

Signed-off-by: default avatarAlexander Usyskin <alexander.usyskin@intel.com>
Signed-off-by: default avatarTomas Winkler <tomas.winkler@intel.com>
Link: https://lore.kernel.org/r/20211223094705.204624-2-tomas.winkler@intel.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 38be5687

drivers/misc/mei/client.c

+4 −0
Original line number Diff line number Diff line
@@ -2327,6 +2327,8 @@ int mei_cl_dma_alloc_and_map(struct mei_cl *cl, const struct file *fp, 
		list_move_tail(&cb->list, &dev->ctrl_rd_list);

	}



	cl->status = 0;



	mutex_unlock(&dev->device_lock);

	wait_event_timeout(cl->wait,

			   cl->dma_mapped || cl->status,
@@ -2404,6 +2406,8 @@ int mei_cl_dma_unmap(struct mei_cl *cl, const struct file *fp) 
		list_move_tail(&cb->list, &dev->ctrl_rd_list);

	}



	cl->status = 0;



	mutex_unlock(&dev->device_lock);

	wait_event_timeout(cl->wait,

			   !cl->dma_mapped || cl->status,