Commit 43aa006e authored by Manivannan Sadhasivam's avatar Manivannan Sadhasivam Committed by Bjorn Andersson
Browse files

dt-bindings: arm: msm: Fix register regions used for LLCC banks 



Register regions of the LLCC banks are located at different addresses.
Currently, the binding just lists the LLCC0 base address and tries to
cover all the banks using a single size. This is entirely wrong as there
are other register regions that happen to lie inside the size covered by
the binding such as the memory controller and holes.

So this needs to be fixed by specifying the base address of individual
LLCC banks. This approach will break the existing users of this binding
as the register regions are split and the drivers now cannot use
LLCC0 register region for accessing rest of the banks (which is wrong
anyway).

But considering the fact that the binding was wrong from the day one and
also the device drivers going wrong by the binding, this breakage is
acceptable.

Reported-by: default avatarParikshit Pareek <quic_ppareek@quicinc.com>
Reviewed-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: default avatarManivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Signed-off-by: default avatarBjorn Andersson <andersson@kernel.org>
Link: https://lore.kernel.org/r/20230314080443.64635-3-manivannan.sadhasivam@linaro.org
parent 94b1d58f

Documentation/devicetree/bindings/arm/msm/qcom,llcc.yaml

+114 −11
Original line number Diff line number Diff line
@@ -33,14 +33,12 @@ properties: 
      - qcom,sm8550-llcc



  reg:

    items:

      - description: LLCC base register region

      - description: LLCC broadcast base register region

    minItems: 2

    maxItems: 9



  reg-names:

    items:

      - const: llcc_base

      - const: llcc_broadcast_base

    minItems: 2

    maxItems: 9



  interrupts:

    maxItems: 1
@@ -50,15 +48,120 @@ required: 
  - reg

  - reg-names



allOf:

  - if:

      properties:

        compatible:

          contains:

            enum:

              - qcom,sc7180-llcc

              - qcom,sm6350-llcc

    then:

      properties:

        reg:

          items:

            - description: LLCC0 base register region

            - description: LLCC broadcast base register region

        reg-names:

          items:

            - const: llcc0_base

            - const: llcc_broadcast_base



  - if:

      properties:

        compatible:

          contains:

            enum:

              - qcom,sc7280-llcc

    then:

      properties:

        reg:

          items:

            - description: LLCC0 base register region

            - description: LLCC1 base register region

            - description: LLCC broadcast base register region

        reg-names:

          items:

            - const: llcc0_base

            - const: llcc1_base

            - const: llcc_broadcast_base



  - if:

      properties:

        compatible:

          contains:

            enum:

              - qcom,sc8180x-llcc

              - qcom,sc8280xp-llcc

    then:

      properties:

        reg:

          items:

            - description: LLCC0 base register region

            - description: LLCC1 base register region

            - description: LLCC2 base register region

            - description: LLCC3 base register region

            - description: LLCC4 base register region

            - description: LLCC5 base register region

            - description: LLCC6 base register region

            - description: LLCC7 base register region

            - description: LLCC broadcast base register region

        reg-names:

          items:

            - const: llcc0_base

            - const: llcc1_base

            - const: llcc2_base

            - const: llcc3_base

            - const: llcc4_base

            - const: llcc5_base

            - const: llcc6_base

            - const: llcc7_base

            - const: llcc_broadcast_base



  - if:

      properties:

        compatible:

          contains:

            enum:

              - qcom,sdm845-llcc

              - qcom,sm8150-llcc

              - qcom,sm8250-llcc

              - qcom,sm8350-llcc

              - qcom,sm8450-llcc

    then:

      properties:

        reg:

          items:

            - description: LLCC0 base register region

            - description: LLCC1 base register region

            - description: LLCC2 base register region

            - description: LLCC3 base register region

            - description: LLCC broadcast base register region

        reg-names:

          items:

            - const: llcc0_base

            - const: llcc1_base

            - const: llcc2_base

            - const: llcc3_base

            - const: llcc_broadcast_base



additionalProperties: false



examples:

  - |

    #include <dt-bindings/interrupt-controller/arm-gic.h>



    soc {

        #address-cells = <2>;

        #size-cells = <2>;



        system-cache-controller@1100000 {

            compatible = "qcom,sdm845-llcc";

      reg = <0x1100000 0x200000>, <0x1300000 0x50000> ;

      reg-names = "llcc_base", "llcc_broadcast_base";

            reg = <0 0x01100000 0 0x50000>, <0 0x01180000 0 0x50000>,

                <0 0x01200000 0 0x50000>, <0 0x01280000 0 0x50000>,

                <0 0x01300000 0 0x50000>;

            reg-names = "llcc0_base", "llcc1_base", "llcc2_base",

                "llcc3_base", "llcc_broadcast_base";

            interrupts = <GIC_SPI 582 IRQ_TYPE_LEVEL_HIGH>;

        };

    };