Commit 43a925e4 authored by Maciej Fijalkowski's avatar Maciej Fijalkowski Committed by Tony Nguyen
Browse files

ice: remove redundant checks in ice_change_mtu 



dev_validate_mtu checks that mtu value specified by user is not less
than min mtu and not greater than max allowed mtu. It is being done
before calling the ndo_change_mtu exposed by driver, so remove these
redundant checks in ice_change_mtu.

Reviewed-by: default avatarBjörn Töpel <bjorn.topel@intel.com>
Signed-off-by: default avatarMaciej Fijalkowski <maciej.fijalkowski@intel.com>
Tested-by: default avatarTony Brelinski <tonyx.brelinski@intel.com>
Signed-off-by: default avatarTony Nguyen <anthony.l.nguyen@intel.com>
parent 29b82f2a

drivers/net/ethernet/intel/ice/ice_main.c

+0 −9
Original line number Diff line number Diff line
@@ -6154,15 +6154,6 @@ static int ice_change_mtu(struct net_device *netdev, int new_mtu) 
		}

	}



	if (new_mtu < (int)netdev->min_mtu) {

		netdev_err(netdev, "new MTU invalid. min_mtu is %d\n",

			   netdev->min_mtu);

		return -EINVAL;

	} else if (new_mtu > (int)netdev->max_mtu) {

		netdev_err(netdev, "new MTU invalid. max_mtu is %d\n",

			   netdev->min_mtu);

		return -EINVAL;

	}

	/* if a reset is in progress, wait for some time for it to complete */

	do {

		if (ice_is_reset_in_progress(pf->state)) {