Unverified Commit 436a5c20 authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Mark Brown
Browse files

spi: cadence-quadspi: Simplify with dev_err_probe() 



Common pattern of handling deferred probe can be simplified with
dev_err_probe().  Less code and the error value gets printed.

Signed-off-by: default avatarKrzysztof Kozlowski <krzk@kernel.org>
Link: https://lore.kernel.org/r/20200901152713.18629-5-krzk@kernel.org


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 65acd82c

drivers/spi/spi-cadence-quadspi.c

+1 −4
Original line number Diff line number Diff line
@@ -1117,11 +1117,8 @@ static int cqspi_request_mmap_dma(struct cqspi_st *cqspi) 
	cqspi->rx_chan = dma_request_chan_by_mask(&mask);

	if (IS_ERR(cqspi->rx_chan)) {

		int ret = PTR_ERR(cqspi->rx_chan);



		if (ret != -EPROBE_DEFER)

			dev_err(&cqspi->pdev->dev, "No Rx DMA available\n");

		cqspi->rx_chan = NULL;

		return ret;

		return dev_err_probe(&cqspi->pdev->dev, ret, "No Rx DMA available\n");

	}

	init_completion(&cqspi->rx_dma_complete);