Commit 434438d8 authored by Dan Carpenter's avatar Dan Carpenter Committed by Greg Kroah-Hartman
Browse files

usb: typec: silence a static checker warning 



Smatch complains about a potential missing error code:

    drivers/usb/typec/port-mapper.c:168 typec_link_port()
    warn: missing error code 'ret'

This is a false positive and returning zero is intentional.  Let's
re-arrange the code to silence the warning and make the intent more
clear.

Reviewed-by: default avatarHeikki Krogerus <heikki.krogerus@linux.intel.com>
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/YHadaACH8Mq/10F7@mwanda


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 401411bb

drivers/usb/typec/port-mapper.c

+4 −2
Original line number Diff line number Diff line
@@ -157,15 +157,17 @@ int typec_link_port(struct device *port) 
{

	struct device *connector;

	struct port_node *node;

	int ret = 0;

	int ret;



	node = create_port_node(port);

	if (IS_ERR(node))

		return PTR_ERR(node);



	connector = find_connector(node);

	if (!connector)

	if (!connector) {

		ret = 0;

		goto remove_node;

	}



	ret = link_port(to_typec_port(connector), node);

	if (ret)