Commit 4329490a authored by Al Viro's avatar Al Viro
Browse files

io_uring_enter(): don't leave f.flags uninitialized 



simplifies logics on cleanup, as well...

Reviewed-by: default avatarJens Axboe <axboe@kernel.dk>
Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
parent 31231092

fs/io_uring.c

+5 −6
Original line number Diff line number Diff line
@@ -10961,13 +10961,13 @@ SYSCALL_DEFINE6(io_uring_enter, unsigned int, fd, u32, to_submit, 
			return -EINVAL;

		fd = array_index_nospec(fd, IO_RINGFD_REG_MAX);

		f.file = tctx->registered_rings[fd];

		if (unlikely(!f.file))

			return -EBADF;

		f.flags = 0;

	} else {

		f = fdget(fd);

	}



	if (unlikely(!f.file))

		return -EBADF;

	}



	ret = -EOPNOTSUPP;

	if (unlikely(f.file->f_op != &io_uring_fops))
@@ -11041,7 +11041,6 @@ SYSCALL_DEFINE6(io_uring_enter, unsigned int, fd, u32, to_submit, 
out:

	percpu_ref_put(&ctx->refs);

out_fput:

	if (!(flags & IORING_ENTER_REGISTERED_RING))

	fdput(f);

	return submitted ? submitted : ret;

}