Commit 430f35b7 authored Mar 12, 2020 by Marco Felsch Committed by Mauro Carvalho Chehab Mar 12, 2020

media: tvp5150: make debug output more readable



The debug output for tvp5150_selmux() isn't really intuitive. Register
values are printed decimal formatted and the input/output driver states
are printed as enum. Even more the "normal" output enum mapps to zero so
a active output will printing output=0 and a inactive output=1.

Change this by brinting the register values hex formatted and the states
as more readable string.

Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

parent baf17821

drivers/media/i2c/tvp5150.c

+6 −3

Original line number	Diff line number	Diff line
		@@ -302,8 +302,11 @@ static void tvp5150_selmux(struct v4l2_subdev *sd)
		break;
		}

		dev_dbg_lvl(sd->dev, 1, debug, "Selecting video route: route input=%i, output=%i => tvp5150 input=%i, opmode=%i\n",
		decoder->input, decoder->output,
		dev_dbg_lvl(sd->dev, 1, debug,
		"Selecting video route: route input=%s, output=%s => tvp5150 input=0x%02x, opmode=0x%02x\n",
		decoder->input == 0 ? "aip1a" :
		decoder->input == 2 ? "aip1b" : "svideo",
		decoder->output == 0 ? "normal" : "black-frame-gen",
		input, opmode);

		regmap_write(decoder->regmap, TVP5150_OP_MODE_CTL, opmode);