Commit 42c02023 authored by Linus Torvalds's avatar Linus Torvalds
Browse files

reserve_region_with_split: Fix GFP_KERNEL usage under spinlock 



This one apparently doesn't generate any warnings, because the function
is only used during system bootup, when the warnings are disabled.  But
it's still very wrong.

The __reserve_region_with_split() function is called with the
resource_lock held for writing, so it must only ever do GFP_ATOMIC
allocations.

Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent cdce1f09

kernel/resource.c

+1 −1
Original line number Diff line number Diff line
@@ -523,7 +523,7 @@ static void __init __reserve_region_with_split(struct resource *root, 
{

	struct resource *parent = root;

	struct resource *conflict;

	struct resource *res = kzalloc(sizeof(*res), GFP_KERNEL);

	struct resource *res = kzalloc(sizeof(*res), GFP_ATOMIC);



	if (!res)

		return;