Commit 42a84c09 authored by Stefano Garzarella's avatar Stefano Garzarella Committed by Michael S. Tsirkin
Browse files

vdpa_sim_blk: use dev_dbg() to print errors 



Use dev_dbg() instead of dev_err()/dev_warn() to avoid flooding the
host with prints, when the guest driver is misbehaving.
In this way, prints can be dynamically enabled when the vDPA block
simulator is used to validate a driver.

Suggested-by: default avatarJason Wang <jasowang@redhat.com>
Acked-by: default avatarJason Wang <jasowang@redhat.com>
Signed-off-by: default avatarStefano Garzarella <sgarzare@redhat.com>
Message-Id: <20220630153221.83371-2-sgarzare@redhat.com>
Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
parent a335b33f

drivers/vdpa/vdpa_sim/vdpa_sim_blk.c

+10 −10
Original line number Diff line number Diff line
@@ -76,13 +76,13 @@ static bool vdpasim_blk_handle_req(struct vdpasim *vdpasim, 
		return false;



	if (vq->out_iov.used < 1 || vq->in_iov.used < 1) {

		dev_err(&vdpasim->vdpa.dev, "missing headers - out_iov: %u in_iov %u\n",

		dev_dbg(&vdpasim->vdpa.dev, "missing headers - out_iov: %u in_iov %u\n",

			vq->out_iov.used, vq->in_iov.used);

		return false;

	}



	if (vq->in_iov.iov[vq->in_iov.used - 1].iov_len < 1) {

		dev_err(&vdpasim->vdpa.dev, "request in header too short\n");

		dev_dbg(&vdpasim->vdpa.dev, "request in header too short\n");

		return false;

	}
@@ -96,7 +96,7 @@ static bool vdpasim_blk_handle_req(struct vdpasim *vdpasim, 
	bytes = vringh_iov_pull_iotlb(&vq->vring, &vq->out_iov, &hdr,

				      sizeof(hdr));

	if (bytes != sizeof(hdr)) {

		dev_err(&vdpasim->vdpa.dev, "request out header too short\n");

		dev_dbg(&vdpasim->vdpa.dev, "request out header too short\n");

		return false;

	}
@@ -110,7 +110,7 @@ static bool vdpasim_blk_handle_req(struct vdpasim *vdpasim, 
	switch (type) {

	case VIRTIO_BLK_T_IN:

		if (!vdpasim_blk_check_range(sector, to_push)) {

			dev_err(&vdpasim->vdpa.dev,

			dev_dbg(&vdpasim->vdpa.dev,

				"reading over the capacity - offset: 0x%llx len: 0x%zx\n",

				offset, to_push);

			status = VIRTIO_BLK_S_IOERR;
@@ -121,7 +121,7 @@ static bool vdpasim_blk_handle_req(struct vdpasim *vdpasim, 
					      vdpasim->buffer + offset,

					      to_push);

		if (bytes < 0) {

			dev_err(&vdpasim->vdpa.dev,

			dev_dbg(&vdpasim->vdpa.dev,

				"vringh_iov_push_iotlb() error: %zd offset: 0x%llx len: 0x%zx\n",

				bytes, offset, to_push);

			status = VIRTIO_BLK_S_IOERR;
@@ -133,7 +133,7 @@ static bool vdpasim_blk_handle_req(struct vdpasim *vdpasim, 


	case VIRTIO_BLK_T_OUT:

		if (!vdpasim_blk_check_range(sector, to_pull)) {

			dev_err(&vdpasim->vdpa.dev,

			dev_dbg(&vdpasim->vdpa.dev,

				"writing over the capacity - offset: 0x%llx len: 0x%zx\n",

				offset, to_pull);

			status = VIRTIO_BLK_S_IOERR;
@@ -144,7 +144,7 @@ static bool vdpasim_blk_handle_req(struct vdpasim *vdpasim, 
					      vdpasim->buffer + offset,

					      to_pull);

		if (bytes < 0) {

			dev_err(&vdpasim->vdpa.dev,

			dev_dbg(&vdpasim->vdpa.dev,

				"vringh_iov_pull_iotlb() error: %zd offset: 0x%llx len: 0x%zx\n",

				bytes, offset, to_pull);

			status = VIRTIO_BLK_S_IOERR;
@@ -157,7 +157,7 @@ static bool vdpasim_blk_handle_req(struct vdpasim *vdpasim, 
					      vdpasim_blk_id,

					      VIRTIO_BLK_ID_BYTES);

		if (bytes < 0) {

			dev_err(&vdpasim->vdpa.dev,

			dev_dbg(&vdpasim->vdpa.dev,

				"vringh_iov_push_iotlb() error: %zd\n", bytes);

			status = VIRTIO_BLK_S_IOERR;

			break;
@@ -167,7 +167,7 @@ static bool vdpasim_blk_handle_req(struct vdpasim *vdpasim, 
		break;



	default:

		dev_warn(&vdpasim->vdpa.dev,

		dev_dbg(&vdpasim->vdpa.dev,

			"Unsupported request type %d\n", type);

		status = VIRTIO_BLK_S_IOERR;

		break;