Commit 42992cf1 authored by Lin Yujun's avatar Lin Yujun Committed by Greg Kroah-Hartman
Browse files

slimbus: qcom-ngd: Add error handling in of_qcom_slim_ngd_register 



No error handling is performed when platform_device_add()
return fails. Refer to the error handling of driver_set_override(),
add error handling for platform_device_add().

Fixes: 917809e2 ("slimbus: ngd: Add qcom SLIMBus NGD driver")
Reviewed-by: default avatarNeil Armstrong <neil.armstrong@linaro.org>
Signed-off-by: default avatarLin Yujun <linyujun809@huawei.com>
Link: https://lore.kernel.org/r/20220914031953.94061-1-linyujun809@huawei.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent bd124456

drivers/slimbus/qcom-ngd-ctrl.c

+7 −1
Original line number Diff line number Diff line
@@ -1470,7 +1470,13 @@ static int of_qcom_slim_ngd_register(struct device *parent, 
		ngd->pdev->dev.of_node = node;

		ctrl->ngd = ngd;



		platform_device_add(ngd->pdev);

		ret = platform_device_add(ngd->pdev);

		if (ret) {

			platform_device_put(ngd->pdev);

			kfree(ngd);

			of_node_put(node);

			return ret;

		}

		ngd->base = ctrl->base + ngd->id * data->offset +

					(ngd->id - 1) * data->size;