Commit 42601e35 authored by Junlin Yang's avatar Junlin Yang Committed by Greg Kroah-Hartman
Browse files

usb: class: cdc-wdm: return the correct errno code 



The "rv" is initialized to "-ENOMEM", because "rv" is re-assigned to
"-EINVAL", when kmalloc & usb_alloc_urb failed, the return value should
return "-ENOMEM" rather than "-EINVAL",so the "rv" assignment is placed
in the position where usb_endpoint_is_int_in is false.

Acked-by: default avatarOliver Neukum <oneukum@suse.com>
Signed-off-by: default avatarJunlin Yang <yangjunlin@yulong.com>
Link: https://lore.kernel.org/r/20210621132415.2341-1-angkery@163.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 8e9910c5

drivers/usb/class/cdc-wdm.c

+3 −2
Original line number Diff line number Diff line
@@ -868,9 +868,10 @@ static int wdm_create(struct usb_interface *intf, struct usb_endpoint_descriptor 
	INIT_WORK(&desc->rxwork, wdm_rxwork);

	INIT_WORK(&desc->service_outs_intr, service_interrupt_work);



	if (!usb_endpoint_is_int_in(ep)) {

		rv = -EINVAL;

	if (!usb_endpoint_is_int_in(ep))

		goto err;

	}



	desc->wMaxPacketSize = usb_endpoint_maxp(ep);