Commit 423cc66b authored by Can Guo's avatar Can Guo Committed by Martin K. Petersen
Browse files

scsi: ufs-qcom: Remove testbus dump in ufs_qcom_dump_dbg_regs 

Dumping testbus registers outputs a lot of information and can cause
stability issues. Remove the dump code.

Link: https://lore.kernel.org/r/1596975355-39813-4-git-send-email-cang@codeaurora.org


Reviewed-by: default avatarHongwu Su <hongwus@codeaurora.org>
Reviewed-by: default avatarAvri Altman <avri.altman@wdc.com>
Reviewed-by: default avatarBean Huo <beanhuo@micron.com>
Reviewed-by: default avatarAsutosh Das <asutoshd@codeaurora.org>
Signed-off-by: default avatarCan Guo <cang@codeaurora.org>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 89dd87ac

drivers/scsi/ufs/ufs-qcom.c

+0 −32
Original line number Diff line number Diff line
@@ -1630,44 +1630,12 @@ int ufs_qcom_testbus_config(struct ufs_qcom_host *host) 
	return 0;

}



static void ufs_qcom_testbus_read(struct ufs_hba *hba)

{

	ufshcd_dump_regs(hba, UFS_TEST_BUS, 4, "UFS_TEST_BUS ");

}



static void ufs_qcom_print_unipro_testbus(struct ufs_hba *hba)

{

	struct ufs_qcom_host *host = ufshcd_get_variant(hba);

	u32 *testbus = NULL;

	int i, nminor = 256, testbus_len = nminor * sizeof(u32);



	testbus = kmalloc(testbus_len, GFP_KERNEL);

	if (!testbus)

		return;



	host->testbus.select_major = TSTBUS_UNIPRO;

	for (i = 0; i < nminor; i++) {

		host->testbus.select_minor = i;

		ufs_qcom_testbus_config(host);

		testbus[i] = ufshcd_readl(hba, UFS_TEST_BUS);

	}

	print_hex_dump(KERN_ERR, "UNIPRO_TEST_BUS ", DUMP_PREFIX_OFFSET,

			16, 4, testbus, testbus_len, false);

	kfree(testbus);

}



static void ufs_qcom_dump_dbg_regs(struct ufs_hba *hba)

{

	ufshcd_dump_regs(hba, REG_UFS_SYS1CLK_1US, 16 * 4,

			 "HCI Vendor Specific Registers ");



	/* sleep a bit intermittently as we are dumping too much data */

	ufs_qcom_print_hw_debug_reg_all(hba, NULL, ufs_qcom_dump_regs_wrapper);

	udelay(1000);

	ufs_qcom_testbus_read(hba);

	udelay(1000);

	ufs_qcom_print_unipro_testbus(hba);

	udelay(1000);

}



/**