Commit 4236a26a authored by wenhuizhang's avatar wenhuizhang Committed by Steve French
Browse files

cifs: remove deadstore in cifs_close_all_deferred_files() 



Deadstore detected by Lukas Bulwahn's CodeChecker Tool (ELISA group).

line 741 struct cifsInodeInfo *cinode;
line 747 cinode = CIFS_I(d_inode(cfile->dentry));
could be deleted.

cinode on filesystem should not be deleted when files are closed,
they are representations of some data fields on a physical disk,
thus no further action is required.
The virtual inode on vfs will be handled by vfs automatically,
and the denotation is inode, which is different from the cinode.

Signed-off-by: default avatarwenhuizhang <wenhui@gwmail.gwu.edu>
Reviewed-by: default avatarAurelien Aptel <aaptel@suse.com>
Signed-off-by: default avatarSteve French <stfrench@microsoft.com>
parent d07f6ca9

fs/cifs/misc.c

+0 −2
Original line number Diff line number Diff line
@@ -738,13 +738,11 @@ void 
cifs_close_all_deferred_files(struct cifs_tcon *tcon)

{

	struct cifsFileInfo *cfile;

	struct cifsInodeInfo *cinode;

	struct list_head *tmp;



	spin_lock(&tcon->open_file_lock);

	list_for_each(tmp, &tcon->openFileList) {

		cfile = list_entry(tmp, struct cifsFileInfo, tlist);

		cinode = CIFS_I(d_inode(cfile->dentry));

		if (delayed_work_pending(&cfile->deferred))

			mod_delayed_work(deferredclose_wq, &cfile->deferred, 0);

	}