Commit 41f67318 authored by Rui Miguel Silva's avatar Rui Miguel Silva Committed by Greg Kroah-Hartman
Browse files

usb: isp1760: do not sleep in field register poll 



When polling for a setup or clear of a register field we were sleeping
in atomic context but using a very tight sleep interval.

Since the use cases for this poll mechanism are only in setup and
stop paths, and in practice this poll is not used most of the times
but needs to be there to comply to hardware setup times, remove the
sleep time and make the poll loop tighter.

Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarRui Miguel Silva <rui.silva@linaro.org>
Link: https://lore.kernel.org/r/20210727100516.4190681-3-rui.silva@linaro.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 7de14c88

drivers/usb/isp1760/isp1760-hcd.c

+3 −3
Original line number Diff line number Diff line
@@ -250,7 +250,7 @@ static int isp1760_hcd_set_and_wait(struct usb_hcd *hcd, u32 field, 
	isp1760_hcd_set(hcd, field);



	return regmap_field_read_poll_timeout(priv->fields[field], val,

					      val, 10, timeout_us);

					      val, 0, timeout_us);

}



static int isp1760_hcd_set_and_wait_swap(struct usb_hcd *hcd, u32 field,
@@ -262,7 +262,7 @@ static int isp1760_hcd_set_and_wait_swap(struct usb_hcd *hcd, u32 field, 
	isp1760_hcd_set(hcd, field);



	return regmap_field_read_poll_timeout(priv->fields[field], val,

					      !val, 10, timeout_us);

					      !val, 0, timeout_us);

}



static int isp1760_hcd_clear_and_wait(struct usb_hcd *hcd, u32 field,
@@ -274,7 +274,7 @@ static int isp1760_hcd_clear_and_wait(struct usb_hcd *hcd, u32 field, 
	isp1760_hcd_clear(hcd, field);



	return regmap_field_read_poll_timeout(priv->fields[field], val,

					      !val, 10, timeout_us);

					      !val, 0, timeout_us);

}



static bool isp1760_hcd_is_set(struct usb_hcd *hcd, u32 field)