Unverified Commit 41f53a65 authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Mark Brown
Browse files

spi/panel: dt-bindings: drop 3-wire from common properties 



The spi-3wire property is device specific and should be accepted only if
device really needs them.  Drop it from common spi-peripheral-props.yaml
schema, mention in few panel drivers which use it and include instead in
the SPI controller bindings.  The controller bindings will provide
spi-3wire type validation and one place for description.  Each device
schema must list the property if it is applicable.

The Samsung S6E63M0 panel uses also spi-cpha/cpol properties on at least
one board (ste-ux500-samsung-janice/dts), so add also these to the
panel's bindings.

Signed-off-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: default avatarRob Herring <robh@kernel.org>
Link: https://lore.kernel.org/r/20220810131311.428645-1-krzysztof.kozlowski@linaro.org


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 0df874c6

Documentation/devicetree/bindings/display/panel/kingdisplay,kd035g6-54nt.yaml

+2 −0
Original line number Diff line number Diff line
@@ -23,6 +23,8 @@ properties: 
  reg: true

  reset-gpios: true



  spi-3wire: true



required:

  - compatible

  - power-supply

Documentation/devicetree/bindings/display/panel/leadtek,ltk035c5444t.yaml

+2 −0
Original line number Diff line number Diff line
@@ -24,6 +24,8 @@ properties: 
  reg: true

  reset-gpios: true



  spi-3wire: true



required:

  - compatible

  - power-supply

Documentation/devicetree/bindings/display/panel/samsung,s6e63m0.yaml

+4 −0
Original line number Diff line number Diff line
@@ -24,6 +24,10 @@ properties: 
  default-brightness: true

  max-brightness: true



  spi-3wire: true

  spi-cpha: true

  spi-cpol: true



  vdd3-supply:

    description: VDD regulator

Documentation/devicetree/bindings/spi/spi-controller.yaml

+5 −0
Original line number Diff line number Diff line
@@ -96,6 +96,11 @@ patternProperties: 
    $ref: spi-peripheral-props.yaml



    properties:

      spi-3wire:

        $ref: /schemas/types.yaml#/definitions/flag

        description:

          The device requires 3-wire mode.



      spi-cpha:

        $ref: /schemas/types.yaml#/definitions/flag

        description:

Documentation/devicetree/bindings/spi/spi-peripheral-props.yaml

+0 −5
Original line number Diff line number Diff line
@@ -29,11 +29,6 @@ properties: 
    description:

      Chip select used by the device.



  spi-3wire:

    $ref: /schemas/types.yaml#/definitions/flag

    description:

      The device requires 3-wire mode.



  spi-cs-high:

    $ref: /schemas/types.yaml#/definitions/flag

    description: