Commit 41bafb31 authored by Aya Levin's avatar Aya Levin Committed by Saeed Mahameed
Browse files

net/mlx5: Fix setting of devlink traps in switchdev mode 



Prevent setting of devlink traps on the uplink while in switchdev mode.
In this mode, it is the SW switch responsibility to handle both packets
with a mismatch in destination MAC or VLAN ID. Therefore, there are no
flow steering tables to trap undesirable packets and driver crashes upon
setting a trap.

Fixes: 241dc159 ("net/mlx5: Notify on trap action by blocking event")
Signed-off-by: default avatarAya Levin <ayal@nvidia.com>
Reviewed-by: default avatarMoshe Shemesh <moshe@nvidia.com>
Reviewed-by: default avatarRoi Dayan <roid@nvidia.com>
Reviewed-by: default avatarTariq Toukan <tariqt@nvidia.com>
Signed-off-by: default avatarSaeed Mahameed <saeedm@nvidia.com>
parent 2afeec08

drivers/net/ethernet/mellanox/mlx5/core/devlink.c

+5 −0
Original line number Diff line number Diff line
@@ -246,6 +246,11 @@ static int mlx5_devlink_trap_action_set(struct devlink *devlink, 
	struct mlx5_devlink_trap *dl_trap;

	int err = 0;



	if (is_mdev_switchdev_mode(dev)) {

		NL_SET_ERR_MSG_MOD(extack, "Devlink traps can't be set in switchdev mode");

		return -EOPNOTSUPP;

	}



	dl_trap = mlx5_find_trap_by_id(dev, trap->id);

	if (!dl_trap) {

		mlx5_core_err(dev, "Devlink trap: Set action on invalid trap id 0x%x", trap->id);