Commit 419f8299 authored by Wan Jiabing's avatar Wan Jiabing Committed by Zhi Wang
Browse files

i915/gvt: Fix NULL pointer dereference in init_mmio_block_handlers 



Fix following coccicheck error:
./drivers/gpu/drm/i915/gvt/handlers.c:2925:35-41: ERROR: block is NULL but dereferenced.

Use gvt->mmio.mmio_block instead of block to avoid NULL pointer
dereference when find_mmio_block returns NULL.

Fixes: e0f74ed4 ("i915/gvt: Separate the MMIO tracking table from GVT-g")
Signed-off-by: default avatarWan Jiabing <wanjiabing@vivo.com>
Signed-off-by: default avatarZhi Wang <zhi.a.wang@intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/20220427115457.836729-1-wanjiabing@vivo.com


Reviewed-by: default avatarZhi Wang <zhi.a.wang@intel.com>
parent 5b95b9d5

drivers/gpu/drm/i915/gvt/handlers.c

+1 −1
Original line number Diff line number Diff line
@@ -2916,7 +2916,7 @@ static int init_mmio_block_handlers(struct intel_gvt *gvt) 
	block = find_mmio_block(gvt, VGT_PVINFO_PAGE);

	if (!block) {

		WARN(1, "fail to assign handlers to mmio block %x\n",

		     i915_mmio_reg_offset(block->offset));

		     i915_mmio_reg_offset(gvt->mmio.mmio_block->offset));

		return -ENODEV;

	}