Commit 417b99bf authored Jan 09, 2021 by Vladimir Oltean Committed by Jakub Kicinski Jan 11, 2021

net: dsa: remove obsolete comments about switchdev transactions



Now that all port object notifiers were converted to be non-transactional,
we can remove the comments that say otherwise.

Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Acked-by: Jiri Pirko <jiri@nvidia.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

parent 1958d581

net/dsa/slave.c

+0 −5

Original line number	Diff line number	Diff line
		@@ -373,11 +373,6 @@ static int dsa_slave_port_obj_add(struct net_device *dev,
		struct dsa_port *dp = dsa_slave_to_port(dev);
		int err;

		/* For the prepare phase, ensure the full set of changes is feasable in
		* one go in order to signal a failure properly. If an operation is not
		* supported, return -EOPNOTSUPP.
		*/

		switch (obj->id) {
		case SWITCHDEV_OBJ_ID_PORT_MDB:
		if (obj->orig_dev != dev)

net/dsa/switch.c

+0 −4

Original line number	Diff line number	Diff line
		@@ -298,10 +298,6 @@ static int dsa_switch_event(struct notifier_block *nb,
		break;
		}

		/* Non-switchdev operations cannot be rolled back. If a DSA driver
		* returns an error during the chained call, switch chips may be in an
		* inconsistent state.
		*/
		if (err)
		dev_dbg(ds->dev, "breaking chain for DSA event %lu (%d)\n",
		event, err);