Commit 41648432 authored by Christophe JAILLET's avatar Christophe JAILLET Committed by Abhinav Kumar
Browse files

drm/msm/hdmi: Fix the error handling path of msm_hdmi_dev_probe() 



If an error occurs after a successful msm_hdmi_get_phy() call, it must be
undone by a corresponding msm_hdmi_put_phy(), as already done in the
remove function.

Fixes: 43736546 ("drm/msm/hdmi: move msm_hdmi_get_phy() to msm_hdmi_dev_probe()")
Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: default avatarAbhinav Kumar <quic_abhinavk@quicinc.com>
Patchwork: https://patchwork.freedesktop.org/patch/514847/
Link: https://lore.kernel.org/r/b3f9da097851e2e42a40dc61458aa98c41c88d0d.1670741386.git.christophe.jaillet@wanadoo.fr


Signed-off-by: default avatarAbhinav Kumar <quic_abhinavk@quicinc.com>
parent 45dac135

drivers/gpu/drm/msm/hdmi/hdmi.c

+10 −2
Original line number Diff line number Diff line
@@ -532,11 +532,19 @@ static int msm_hdmi_dev_probe(struct platform_device *pdev) 


	ret = devm_pm_runtime_enable(&pdev->dev);

	if (ret)

		return ret;

		goto err_put_phy;



	platform_set_drvdata(pdev, hdmi);



	return component_add(&pdev->dev, &msm_hdmi_ops);

	ret = component_add(&pdev->dev, &msm_hdmi_ops);

	if (ret)

		goto err_put_phy;



	return 0;



err_put_phy:

	msm_hdmi_put_phy(hdmi);

	return ret;

}



static int msm_hdmi_dev_remove(struct platform_device *pdev)