Commit 415ba26c authored by Heikki Krogerus's avatar Heikki Krogerus Committed by Greg Kroah-Hartman
Browse files

usb: typec: ucsi: Remove incorrect warning 



Sink only devices do not have any source capabilities, so
the driver should not warn about that. Also DRP (Dual Role
Power) capable devices, such as USB Type-C docking stations,
do not return any source capabilities unless they are
plugged to a power supply themselves.

Fixes: 1f4642b7 ("usb: typec: ucsi: Retrieve all the PDOs instead of just the first 4")
Reported-by: default avatarPaul Menzel <pmenzel@molgen.mpg.de>
Cc: <stable@vger.kernel.org>
Signed-off-by: default avatarHeikki Krogerus <heikki.krogerus@linux.intel.com>
Link: https://lore.kernel.org/r/20220922145924.80667-1-heikki.krogerus@linux.intel.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent f208ce4d

drivers/usb/typec/ucsi/ucsi.c

+0 −2
Original line number Diff line number Diff line
@@ -588,8 +588,6 @@ static int ucsi_get_pdos(struct ucsi_connector *con, int is_partner, 
				num_pdos * sizeof(u32));

	if (ret < 0 && ret != -ETIMEDOUT)

		dev_err(ucsi->dev, "UCSI_GET_PDOS failed (%d)\n", ret);

	if (ret == 0 && offset == 0)

		dev_warn(ucsi->dev, "UCSI_GET_PDOS returned 0 bytes\n");



	return ret;

}