Commit 4139f992 authored by Minjie Du's avatar Minjie Du Committed by Damien Le Moal
Browse files

ata: pata_arasan_cf: Use dev_err_probe() instead dev_err() in data_xfer() 



It is possible for dma_request_chan() to return EPROBE_DEFER, which
means acdev->host->dev is not ready yet. At this point dev_err() will
have no output. Use dev_err_probe() instead.

Signed-off-by: default avatarMinjie Du <duminjie@vivo.com>
Acked-by: default avatarViresh Kumar <viresh.kumar@linaro.org>
Reviewed-by: default avatarSergey Shtylyov <s.shtylyov@omp.ru>
Signed-off-by: default avatarDamien Le Moal <dlemoal@kernel.org>
parent cec148c2

drivers/ata/pata_arasan_cf.c

+2 −1
Original line number Diff line number Diff line
@@ -529,7 +529,8 @@ static void data_xfer(struct work_struct *work) 
	/* dma_request_channel may sleep, so calling from process context */

	acdev->dma_chan = dma_request_chan(acdev->host->dev, "data");

	if (IS_ERR(acdev->dma_chan)) {

		dev_err(acdev->host->dev, "Unable to get dma_chan\n");

		dev_err_probe(acdev->host->dev, PTR_ERR(acdev->dma_chan),

			      "Unable to get dma_chan\n");

		acdev->dma_chan = NULL;

		goto chan_request_fail;

	}