Commit 41320b18 authored by Zhu Wang's avatar Zhu Wang Committed by Martin K. Petersen
Browse files

scsi: snic: Fix possible memory leak if device_add() fails 



If device_add() returns error, the name allocated by dev_set_name() needs
be freed. As the comment of device_add() says, put_device() should be used
to give up the reference in the error path. So fix this by calling
put_device(), then the name can be freed in kobject_cleanp().

Fixes: c8806b6c ("snic: driver for Cisco SCSI HBA")
Signed-off-by: default avatarZhu Wang <wangzhu9@huawei.com>
Acked-by: default avatarNarsimhulu Musini <nmusini@cisco.com>
Link: https://lore.kernel.org/r/20230801111421.63651-1-wangzhu9@huawei.com


Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 04b5b5cb

drivers/scsi/snic/snic_disc.c

+1 −0
Original line number Diff line number Diff line
@@ -303,6 +303,7 @@ snic_tgt_create(struct snic *snic, struct snic_tgt_id *tgtid) 
			      "Snic Tgt: device_add, with err = %d\n",

			      ret);



		put_device(&tgt->dev);

		put_device(&snic->shost->shost_gendev);

		spin_lock_irqsave(snic->shost->host_lock, flags);

		list_del(&tgt->list);