Commit 412d19b4 authored by Lorenzo Bianconi's avatar Lorenzo Bianconi Committed by Felix Fietkau
Browse files

wifi: mt76: mt7915: fix memory leak in mt7915_mmio_wed_init_rx_buf 



Free mt76_txwi_cache pointer in mt7915_mmio_wed_init_rx_buf routine in
case of failure.

Fixes: 4f831d18 ("wifi: mt76: mt7915: enable WED RX support")
Signed-off-by: default avatarLorenzo Bianconi <lorenzo@kernel.org>
Signed-off-by: default avatarFelix Fietkau <nbd@nbd.name>
parent c222f77f

drivers/net/wireless/mediatek/mt76/mt7915/mmio.c

+8 −1
Original line number Diff line number Diff line
@@ -635,9 +635,14 @@ static u32 mt7915_mmio_wed_init_rx_buf(struct mtk_wed_device *wed, int size) 
		int token;

		void *ptr;



		if (!t)

			goto unmap;



		page = __dev_alloc_pages(GFP_KERNEL, get_order(length));

		if (!page)

		if (!page) {

			mt76_put_rxwi(&dev->mt76, t);

			goto unmap;

		}



		ptr = page_address(page);

		phy_addr = dma_map_single(dev->mt76.dma_dev, ptr,
@@ -645,6 +650,7 @@ static u32 mt7915_mmio_wed_init_rx_buf(struct mtk_wed_device *wed, int size) 
					  DMA_TO_DEVICE);

		if (unlikely(dma_mapping_error(dev->mt76.dev, phy_addr))) {

			__free_pages(page, get_order(length));

			mt76_put_rxwi(&dev->mt76, t);

			goto unmap;

		}
@@ -654,6 +660,7 @@ static u32 mt7915_mmio_wed_init_rx_buf(struct mtk_wed_device *wed, int size) 
			dma_unmap_single(dev->mt76.dma_dev, phy_addr,

					 wed->wlan.rx_size, DMA_TO_DEVICE);

			__free_pages(page, get_order(length));

			mt76_put_rxwi(&dev->mt76, t);

			goto unmap;

		}