Commit 4118879b authored by Nilesh Javali's avatar Nilesh Javali Committed by Martin K. Petersen
Browse files

scsi: qedi: Mark all connections for recovery on link down event 

For short time cable pulls, the in-flight I/O to the firmware is never
cleaned up, resulting in the behaviour of stale I/O completion causing
list_del corruption and soft lockup of the system.

On link down event, mark all the connections for recovery, causing cleanup
of all the in-flight I/O immediately.

Link: https://lore.kernel.org/r/20200908095657.26821-7-mrangankar@marvell.com


Signed-off-by: default avatarNilesh Javali <njavali@marvell.com>
Signed-off-by: default avatarManish Rangankar <mrangankar@marvell.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 5a2e69af

drivers/scsi/qedi/qedi_main.c

+10 −0
Original line number Diff line number Diff line
@@ -1126,6 +1126,15 @@ static void qedi_schedule_recovery_handler(void *dev) 
	schedule_delayed_work(&qedi->recovery_work, 0);

}



static void qedi_set_conn_recovery(struct iscsi_cls_session *cls_session)

{

	struct iscsi_session *session = cls_session->dd_data;

	struct iscsi_conn *conn = session->leadconn;

	struct qedi_conn *qedi_conn = conn->dd_data;



	qedi_start_conn_recovery(qedi_conn->qedi, qedi_conn);

}



static void qedi_link_update(void *dev, struct qed_link_output *link)

{

	struct qedi_ctx *qedi = (struct qedi_ctx *)dev;
@@ -1137,6 +1146,7 @@ static void qedi_link_update(void *dev, struct qed_link_output *link) 
		QEDI_INFO(&qedi->dbg_ctx, QEDI_LOG_INFO,

			  "Link Down event.\n");

		atomic_set(&qedi->link_state, QEDI_LINK_DOWN);

		iscsi_host_for_each_session(qedi->shost, qedi_set_conn_recovery);

	}

}