Commit 410b6de7 authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Richard Weinberger
Browse files

ubifs: replay: Fix high stack usage, again 



An earlier commit moved out some functions to not be inlined by gcc, but
after some other rework to remove one of those, clang started inlining
the other one and ran into the same problem as gcc did before:

fs/ubifs/replay.c:1174:5: error: stack frame size of 1152 bytes in function 'ubifs_replay_journal' [-Werror,-Wframe-larger-than=]

Mark the function as noinline_for_stack to ensure it doesn't happen
again.

Fixes: f80df385 ("ubifs: use crypto_shash_tfm_digest()")
Fixes: eb66eff6 ("ubifs: replay: Fix high stack usage")
Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Reviewed-by: default avatarNathan Chancellor <natechancellor@gmail.com>
Signed-off-by: default avatarRichard Weinberger <richard@nod.at>
parent 11b8ab38

fs/ubifs/replay.c

+3 −1
Original line number Diff line number Diff line
@@ -559,7 +559,9 @@ static int is_last_bud(struct ubifs_info *c, struct ubifs_bud *bud) 
}



/* authenticate_sleb_hash is split out for stack usage */

static int authenticate_sleb_hash(struct ubifs_info *c, struct shash_desc *log_hash, u8 *hash)

static int noinline_for_stack

authenticate_sleb_hash(struct ubifs_info *c,

		       struct shash_desc *log_hash, u8 *hash)

{

	SHASH_DESC_ON_STACK(hash_desc, c->hash_tfm);