Commit 41082203 authored by Qiushi Wu's avatar Qiushi Wu Committed by Mauro Carvalho Chehab
Browse files

media: rcar-vin: Fix a reference count leak. 



pm_runtime_get_sync() increments the runtime PM usage counter even
when it returns an error code. Thus call pm_runtime_put_noidle()
if pm_runtime_get_sync() fails.

Fixes: 2a18fbec ("media: rcar-vin: Move pm_runtime_{get,put} out of helpers")
Signed-off-by: default avatarQiushi Wu <wu000273@umn.edu>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
parent aaffa012

drivers/media/platform/rcar-vin/rcar-v4l2.c

+3 −1
Original line number Diff line number Diff line
@@ -844,8 +844,10 @@ static int rvin_open(struct file *file) 
	int ret;



	ret = pm_runtime_get_sync(vin->dev);

	if (ret < 0)

	if (ret < 0) {

		pm_runtime_put_noidle(vin->dev);

		return ret;

	}



	ret = mutex_lock_interruptible(&vin->lock);

	if (ret)