Commit 40fcc7fc authored Dec 29, 2021 by Matthew Wilcox (Oracle)

mm: Remove page_cache_add_speculative() and page_cache_get_speculative()



These wrappers have no more callers, so delete them.

Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: John Hubbard <jhubbard@nvidia.com>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Reviewed-by: William Kucharski <william.kucharski@oracle.com>

parent 5fec0719

include/linux/mm.h

+3 −4

Original line number	Diff line number	Diff line
		@@ -1215,10 +1215,9 @@ static inline void put_page(struct page *page)
		* applications that don't have huge page reference counts, this won't be an
		* issue.
		*
		* Locking: the lockless algorithm described in page_cache_get_speculative()
		* and page_cache_gup_pin_speculative() provides safe operation for
		* get_user_pages and page_mkclean and other calls that race to set up page
		* table entries.
		* Locking: the lockless algorithm described in folio_try_get_rcu()
		* provides safe operation for get_user_pages(), page_mkclean() and
		* other calls that race to set up page table entries.
		*/
		#define GUP_PIN_COUNTING_BIAS (1U << 10)

include/linux/pagemap.h

+0 −10

Original line number	Diff line number	Diff line
		@@ -283,16 +283,6 @@ static inline struct inode folio_inode(struct folio folio)
		return folio->mapping->host;
		}

		static inline bool page_cache_add_speculative(struct page *page, int count)
		{
		return folio_ref_try_add_rcu((struct folio *)page, count);
		}

		static inline bool page_cache_get_speculative(struct page *page)
		{
		return page_cache_add_speculative(page, 1);
		}

		/**
		* folio_attach_private - Attach private data to a folio.
		* @folio: Folio to attach data to.