Commit 40fa7394 authored by Colin Ian King's avatar Colin Ian King Committed by Martin K. Petersen
Browse files

scsi: pm80xx: Fix potential infinite loop 

The for-loop iterates with a u8 loop counter i and compares this with the
loop upper limit of pm8001_ha->max_q_num which is a u32 type.  There is a
potential infinite loop if pm8001_ha->max_q_num is larger than the u8 loop
counter. Fix this by making the loop counter the same type as
pm8001_ha->max_q_num.

[mkp: this is purely theoretical, max_q_num is currently limited to 64]

Link: https://lore.kernel.org/r/20210407135840.494747-1-colin.king@canonical.com


Fixes: 65df7d19 ("scsi: pm80xx: Fix chip initialization failure")
Addresses-Coverity: ("Infinite loop")
Reviewed-by: default avatarJohannes Thumshirn <johannes.thumshirn@wdc.com>
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 6f305bf6

drivers/scsi/pm8001/pm8001_hwi.c

+1 −1
Original line number Diff line number Diff line
@@ -643,7 +643,7 @@ static void init_pci_device_addresses(struct pm8001_hba_info *pm8001_ha) 
 */

static int pm8001_chip_init(struct pm8001_hba_info *pm8001_ha)

{

	u8 i = 0;

	u32 i = 0;

	u16 deviceid;

	pci_read_config_word(pm8001_ha->pdev, PCI_DEVICE_ID, &deviceid);

	/* 8081 controllers need BAR shift to access MPI space