Commit 40f567bb authored by Jia-Ju Bai's avatar Jia-Ju Bai Committed by Jens Axboe
Browse files

md: bcache: check the return value of kzalloc() in detached_dev_do_request() 



The function kzalloc() in detached_dev_do_request() can fail, so its
return value should be checked.

Fixes: bc082a55 ("bcache: fix inaccurate io state for detached bcache devices")
Reported-by: default avatarTOTE Robot <oslab@tsinghua.edu.cn>
Signed-off-by: default avatarJia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: default avatarColy Li <colyli@suse.de>
Link: https://lore.kernel.org/r/20220527152818.27545-4-colyli@suse.de


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 7d6b902e

drivers/md/bcache/request.c

+6 −0
Original line number Diff line number Diff line
@@ -1105,6 +1105,12 @@ static void detached_dev_do_request(struct bcache_device *d, struct bio *bio, 
	 * which would call closure_get(&dc->disk.cl)

	 */

	ddip = kzalloc(sizeof(struct detached_dev_io_private), GFP_NOIO);

	if (!ddip) {

		bio->bi_status = BLK_STS_RESOURCE;

		bio->bi_end_io(bio);

		return;

	}



	ddip->d = d;

	/* Count on the bcache device */

	ddip->orig_bdev = orig_bdev;