Commit 40f43730 authored by Dan Carpenter's avatar Dan Carpenter Committed by Laurent Pinchart
Browse files

drm: rcar-du: Fix a NULL vs IS_ERR() bug 



The drmm_encoder_alloc() function returns error pointers.  It never
returns NULL.  Fix the check accordingly.

Fixes: 7a1adbd2 ("drm: rcar-du: Use drmm_encoder_alloc() to manage encoder")
Signed-off-by: default avatarDan Carpenter <error27@gmail.com>
Reviewed-by: default avatarKieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Reviewed-by: default avatarLaurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Signed-off-by: default avatarLaurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
parent 944eb068

drivers/gpu/drm/rcar-du/rcar_du_encoder.c

+2 −2
Original line number Diff line number Diff line
@@ -109,8 +109,8 @@ int rcar_du_encoder_init(struct rcar_du_device *rcdu, 
	renc = drmm_encoder_alloc(&rcdu->ddev, struct rcar_du_encoder, base,

				  &rcar_du_encoder_funcs, DRM_MODE_ENCODER_NONE,

				  NULL);

	if (!renc)

		return -ENOMEM;

	if (IS_ERR(renc))

		return PTR_ERR(renc);



	renc->output = output;