Commit 40e1bcab authored by Viktor Malik's avatar Viktor Malik Committed by Andrii Nakryiko
Browse files

libbpf: Remove unnecessary ternary operator 



Coverity reports that the first check of 'err' in bpf_object__init_maps
is always false as 'err' is initialized to 0 at that point. Remove the
unnecessary ternary operator.

Signed-off-by: default avatarViktor Malik <vmalik@redhat.com>
Signed-off-by: default avatarAndrii Nakryiko <andrii@kernel.org>
Link: https://lore.kernel.org/bpf/78a3702f2ea9f32a84faaae9b674c56269d330a7.1677658777.git.vmalik@redhat.com
parent be35f4af

tools/lib/bpf/libbpf.c

+1 −1
Original line number Diff line number Diff line
@@ -2615,7 +2615,7 @@ static int bpf_object__init_maps(struct bpf_object *obj, 
	strict = !OPTS_GET(opts, relaxed_maps, false);

	pin_root_path = OPTS_GET(opts, pin_root_path, NULL);



	err = err ?: bpf_object__init_user_btf_maps(obj, strict, pin_root_path);

	err = bpf_object__init_user_btf_maps(obj, strict, pin_root_path);

	err = err ?: bpf_object__init_global_data_maps(obj);

	err = err ?: bpf_object__init_kconfig_map(obj);

	err = err ?: bpf_object__init_struct_ops_maps(obj);