Commit 40e0447d authored by Barnabás Pőcze's avatar Barnabás Pőcze Committed by Hans de Goede
Browse files

platform/x86: ideapad-laptop: use msecs_to_jiffies() helper instead of hand-crafted formula 



The current code used a hand-crafted formula to convert milliseconds to
jiffies, replace it with the msecs_to_jiffies() function. Furthermore,
use a while loop instead of for loop for shorter lines and simplicity.

Signed-off-by: default avatarBarnabás Pőcze <pobrn@protonmail.com>
Link: https://lore.kernel.org/r/20210203215403.290792-11-pobrn@protonmail.com


Reviewed-by: default avatarHans de Goede <hdegoede@redhat.com>
Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
parent 0c4915b6

drivers/platform/x86/ideapad-laptop.c

+7 −4
Original line number Diff line number Diff line
@@ -19,6 +19,7 @@ 
#include <linux/init.h>

#include <linux/input.h>

#include <linux/input/sparse-keymap.h>

#include <linux/jiffies.h>

#include <linux/kernel.h>

#include <linux/module.h>

#include <linux/platform_device.h>
@@ -221,8 +222,9 @@ static int read_ec_data(acpi_handle handle, int cmd, unsigned long *data) 
	if (method_vpcw(handle, 1, cmd))

		return -1;



	for (end_jiffies = jiffies+(HZ)*IDEAPAD_EC_TIMEOUT/1000+1;

	     time_before(jiffies, end_jiffies);) {

	end_jiffies = jiffies + msecs_to_jiffies(IDEAPAD_EC_TIMEOUT) + 1;



	while (time_before(jiffies, end_jiffies)) {

		schedule();

		if (method_vpcr(handle, 1, &val))

			return -1;
@@ -247,8 +249,9 @@ static int write_ec_cmd(acpi_handle handle, int cmd, unsigned long data) 
	if (method_vpcw(handle, 1, cmd))

		return -1;



	for (end_jiffies = jiffies+(HZ)*IDEAPAD_EC_TIMEOUT/1000+1;

	     time_before(jiffies, end_jiffies);) {

	end_jiffies = jiffies + msecs_to_jiffies(IDEAPAD_EC_TIMEOUT) + 1;



	while (time_before(jiffies, end_jiffies)) {

		schedule();

		if (method_vpcr(handle, 1, &val))

			return -1;