Commit 40c1ca07 authored by Zhangfei Gao's avatar Zhangfei Gao Committed by Jason Zeng
Browse files

iommu/sva: Fix SVA handle sharing in multi device case 

mainline inclusion
from mainline-v6.8-rc7
commit 6384c56c99d98c84afea5b9ec7029a6e153ae431
category: feature
bugzilla: https://gitee.com/openeuler/kernel/issues/I938E2
CVE: NA

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=6384c56c99d98c84afea5b9ec7029a6e153ae431



--------------------------------

iommu_sva_bind_device will directly goto out in multi-device
case when found existing domain, ignoring list_add handle,
which causes the handle to fail to be shared.

Fixes: 65d4418c5002 ("iommu/sva: Restore SVA handle sharing")
Signed-off-by: default avatarZhangfei Gao <zhangfei.gao@linaro.org>
Reviewed-by: default avatarJason Gunthorpe <jgg@nvidia.com>
Reviewed-by: default avatarLu Baolu <baolu.lu@linux.intel.com>
Reviewed-by: default avatarKevin Tian <kevin.tian@intel.com>
Link: https://lore.kernel.org/r/20240227064821.128-1-zhangfei.gao@linaro.org


Signed-off-by: default avatarJoerg Roedel <jroedel@suse.de>
Signed-off-by: default avatarJason Zeng <jason.zeng@intel.com>
parent fbcd4a30

drivers/iommu/iommu-sva.c

+2 −2
Original line number Diff line number Diff line
@@ -117,11 +117,11 @@ struct iommu_sva *iommu_sva_bind_device(struct device *dev, struct mm_struct *mm 
	if (ret)

		goto out_free_domain;

	domain->users = 1;

	refcount_set(&handle->users, 1);

	list_add(&domain->next, &mm->iommu_mm->sva_domains);

	list_add(&handle->handle_item, &mm->iommu_mm->sva_handles);



out:

	refcount_set(&handle->users, 1);

	list_add(&handle->handle_item, &mm->iommu_mm->sva_handles);

	mutex_unlock(&iommu_sva_lock);

	handle->dev = dev;

	handle->domain = domain;