Unverified Commit 4084c8ca authored Apr 01, 2023 by Christophe Leroy Committed by Mark Brown Apr 05, 2023

spi: fsl-spi: No need to check transfer length versus word size



The verification is already do in the SPI core by function
__spi_validate(), not it to check it again in fsl_spi_bufs().

Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
Link: https://lore.kernel.org/r/9ace69a8085e22fafd9159e99edd7bbfae2f9940.1680371809.git.christophe.leroy@csgroup.eu


Signed-off-by: Mark Brown <broonie@kernel.org>

parent 99aebb3c

drivers/spi/spi-fsl-spi.c

+2 −10

Original line number	Diff line number	Diff line
		@@ -263,18 +263,10 @@ static int fsl_spi_bufs(struct spi_device spi, struct spi_transfer t,
		if (t->bits_per_word)
		bits_per_word = t->bits_per_word;

		if (bits_per_word > 8) {
		/* invalid length? */
		if (len & 1)
		return -EINVAL;
		if (bits_per_word > 8)
		len /= 2;
		}
		if (bits_per_word > 16) {
		/* invalid length? */
		if (len & 1)
		return -EINVAL;
		if (bits_per_word > 16)
		len /= 2;
		}

		mpc8xxx_spi->tx = t->tx_buf;
		mpc8xxx_spi->rx = t->rx_buf;