Commit 404dd7df authored by Wolfram Sang's avatar Wolfram Sang Committed by Daniel Lezcano
Browse files

drivers/thermal/rcar_gen3_thermal: Improve logging during probe 



When setting up a new board, a plain "Can't register thermal zone"
didn't help me much because the thermal zones in DT were all fine. I
just had a sensor entry too much in the parent TSC node. Reword the
failure/success messages to contain the sensor number to make it easier
to understand which sensor is affected. Example output now:

rcar_gen3_thermal e6198000.thermal: Sensor 0: Loaded 1 trip points
rcar_gen3_thermal e6198000.thermal: Sensor 1: Loaded 1 trip points
rcar_gen3_thermal e6198000.thermal: Sensor 2: Loaded 1 trip points
rcar_gen3_thermal e6198000.thermal: Sensor 3: Can't register thermal zone

Signed-off-by: default avatarWolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: default avatarNiklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Link: https://lore.kernel.org/r/20220610200500.6727-1-wsa+renesas@sang-engineering.com


Signed-off-by: default avatarDaniel Lezcano <daniel.lezcano@linaro.org>
parent 037a6ea0

drivers/thermal/rcar_gen3_thermal.c

+2 −2
Original line number Diff line number Diff line
@@ -507,7 +507,7 @@ static int rcar_gen3_thermal_probe(struct platform_device *pdev) 
		zone = devm_thermal_zone_of_sensor_register(dev, i, tsc,

							    &rcar_gen3_tz_of_ops);

		if (IS_ERR(zone)) {

			dev_err(dev, "Can't register thermal zone\n");

			dev_err(dev, "Sensor %u: Can't register thermal zone\n", i);

			ret = PTR_ERR(zone);

			goto error_unregister;

		}
@@ -529,7 +529,7 @@ static int rcar_gen3_thermal_probe(struct platform_device *pdev) 
		if (ret < 0)

			goto error_unregister;



		dev_info(dev, "TSC%u: Loaded %d trip points\n", i, ret);

		dev_info(dev, "Sensor %u: Loaded %d trip points\n", i, ret);

	}



	if (!priv->num_tscs) {