Commit 3fb5c904 authored by Yang Yingliang's avatar Yang Yingliang Committed by Linus Walleij
Browse files

pinctrl: zynqmp: Drop pinctrl_unregister for devm_ registered device 



It's not necessary to unregister pin controller device registered
with devm_pinctrl_register() and using pinctrl_unregister() leads
to a double free.

Fixes: fa99e701 ("pinctrl: zynqmp: some code cleanups")
Signed-off-by: default avatarYang Yingliang <yangyingliang@huawei.com>
Reviewed-by: default avatarMichal Simek <michal.simek@xilinx.com>
Link: https://lore.kernel.org/r/20210729071905.3235953-1-yangyingliang@huawei.com


Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent f03f5c75

drivers/pinctrl/pinctrl-zynqmp.c

+0 −10
Original line number Diff line number Diff line
@@ -866,15 +866,6 @@ static int zynqmp_pinctrl_probe(struct platform_device *pdev) 
	return ret;

}



static int zynqmp_pinctrl_remove(struct platform_device *pdev)

{

	struct zynqmp_pinctrl *pctrl = platform_get_drvdata(pdev);



	pinctrl_unregister(pctrl->pctrl);



	return 0;

}



static const struct of_device_id zynqmp_pinctrl_of_match[] = {

	{ .compatible = "xlnx,zynqmp-pinctrl" },

	{ }
@@ -887,7 +878,6 @@ static struct platform_driver zynqmp_pinctrl_driver = { 
		.of_match_table = zynqmp_pinctrl_of_match,

	},

	.probe = zynqmp_pinctrl_probe,

	.remove = zynqmp_pinctrl_remove,

};

module_platform_driver(zynqmp_pinctrl_driver);