Commit 3f9c066a authored by David S. Miller's avatar David S. Miller
Browse files

Merge branch 'ipa-qmi-fixes' 



Alex Elder says:

====================
net: ipa: QMI fixes

Mani Sadhasivam discovered some errors in the definitions of some
QMI messages used for IPA.  This series addresses those errors,
and extends the definition of one message type to include some
newly-defined fields.
====================

Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parents 6f0d3250 6ec7a9c2

drivers/net/ipa/ipa_qmi_msg.c

+69 −9
Original line number Diff line number Diff line
@@ -56,7 +56,7 @@ struct qmi_elem_info ipa_indication_register_req_ei[] = { 
		.elem_size	=

			sizeof_field(struct ipa_indication_register_req,

				     ipa_mhi_ready_ind_valid),

		.tlv_type	= 0x11,

		.tlv_type	= 0x12,

		.offset		= offsetof(struct ipa_indication_register_req,

					   ipa_mhi_ready_ind_valid),

	},
@@ -66,10 +66,50 @@ struct qmi_elem_info ipa_indication_register_req_ei[] = { 
		.elem_size	=

			sizeof_field(struct ipa_indication_register_req,

				     ipa_mhi_ready_ind),

		.tlv_type	= 0x11,

		.tlv_type	= 0x12,

		.offset		= offsetof(struct ipa_indication_register_req,

					   ipa_mhi_ready_ind),

	},

	{

		.data_type	= QMI_OPT_FLAG,

		.elem_len	= 1,

		.elem_size	=

			sizeof_field(struct ipa_indication_register_req,

				     endpoint_desc_ind_valid),

		.tlv_type	= 0x13,

		.offset		= offsetof(struct ipa_indication_register_req,

					   endpoint_desc_ind_valid),

	},

	{

		.data_type	= QMI_UNSIGNED_1_BYTE,

		.elem_len	= 1,

		.elem_size	=

			sizeof_field(struct ipa_indication_register_req,

				     endpoint_desc_ind),

		.tlv_type	= 0x13,

		.offset		= offsetof(struct ipa_indication_register_req,

					   endpoint_desc_ind),

	},

	{

		.data_type	= QMI_OPT_FLAG,

		.elem_len	= 1,

		.elem_size	=

			sizeof_field(struct ipa_indication_register_req,

				     bw_change_ind_valid),

		.tlv_type	= 0x14,

		.offset		= offsetof(struct ipa_indication_register_req,

					   bw_change_ind_valid),

	},

	{

		.data_type	= QMI_UNSIGNED_1_BYTE,

		.elem_len	= 1,

		.elem_size	=

			sizeof_field(struct ipa_indication_register_req,

				     bw_change_ind),

		.tlv_type	= 0x14,

		.offset		= offsetof(struct ipa_indication_register_req,

					   bw_change_ind),

	},

	{

		.data_type	= QMI_EOTI,

	},
@@ -530,7 +570,7 @@ struct qmi_elem_info ipa_init_modem_driver_req_ei[] = { 
					   hw_stats_quota_base_addr_valid),

	},

	{

		.data_type	= QMI_SIGNED_4_BYTE_ENUM,

		.data_type	= QMI_UNSIGNED_4_BYTE,

		.elem_len	= 1,

		.elem_size	=

			sizeof_field(struct ipa_init_modem_driver_req,
@@ -545,37 +585,57 @@ struct qmi_elem_info ipa_init_modem_driver_req_ei[] = { 
		.elem_size	=

			sizeof_field(struct ipa_init_modem_driver_req,

				     hw_stats_quota_size_valid),

		.tlv_type	= 0x1f,

		.tlv_type	= 0x20,

		.offset		= offsetof(struct ipa_init_modem_driver_req,

					   hw_stats_quota_size_valid),

	},

	{

		.data_type	= QMI_SIGNED_4_BYTE_ENUM,

		.data_type	= QMI_UNSIGNED_4_BYTE,

		.elem_len	= 1,

		.elem_size	=

			sizeof_field(struct ipa_init_modem_driver_req,

				     hw_stats_quota_size),

		.tlv_type	= 0x1f,

		.tlv_type	= 0x20,

		.offset		= offsetof(struct ipa_init_modem_driver_req,

					   hw_stats_quota_size),

	},

	{

		.data_type	= QMI_OPT_FLAG,

		.elem_len	= 1,

		.elem_size	=

			sizeof_field(struct ipa_init_modem_driver_req,

				     hw_stats_drop_base_addr_valid),

		.tlv_type	= 0x21,

		.offset		= offsetof(struct ipa_init_modem_driver_req,

					   hw_stats_drop_base_addr_valid),

	},

	{

		.data_type	= QMI_UNSIGNED_4_BYTE,

		.elem_len	= 1,

		.elem_size	=

			sizeof_field(struct ipa_init_modem_driver_req,

				     hw_stats_drop_base_addr),

		.tlv_type	= 0x21,

		.offset		= offsetof(struct ipa_init_modem_driver_req,

					   hw_stats_drop_base_addr),

	},

	{

		.data_type	= QMI_OPT_FLAG,

		.elem_len	= 1,

		.elem_size	=

			sizeof_field(struct ipa_init_modem_driver_req,

				     hw_stats_drop_size_valid),

		.tlv_type	= 0x1f,

		.tlv_type	= 0x22,

		.offset		= offsetof(struct ipa_init_modem_driver_req,

					   hw_stats_drop_size_valid),

	},

	{

		.data_type	= QMI_SIGNED_4_BYTE_ENUM,

		.data_type	= QMI_UNSIGNED_4_BYTE,

		.elem_len	= 1,

		.elem_size	=

			sizeof_field(struct ipa_init_modem_driver_req,

				     hw_stats_drop_size),

		.tlv_type	= 0x1f,

		.tlv_type	= 0x22,

		.offset		= offsetof(struct ipa_init_modem_driver_req,

					   hw_stats_drop_size),

	},

drivers/net/ipa/ipa_qmi_msg.h

+5 −1
Original line number Diff line number Diff line
@@ -24,7 +24,7 @@ 
 * information for each field.  The qmi_send_*() interfaces require

 * the message size to be provided.

 */

#define IPA_QMI_INDICATION_REGISTER_REQ_SZ	12	/* -> server handle */

#define IPA_QMI_INDICATION_REGISTER_REQ_SZ	20	/* -> server handle */

#define IPA_QMI_INDICATION_REGISTER_RSP_SZ	7	/* <- server handle */

#define IPA_QMI_INIT_DRIVER_REQ_SZ		162	/* client handle -> */

#define IPA_QMI_INIT_DRIVER_RSP_SZ		25	/* client handle <- */
@@ -44,6 +44,10 @@ struct ipa_indication_register_req { 
	u8 data_usage_quota_reached;

	u8 ipa_mhi_ready_ind_valid;

	u8 ipa_mhi_ready_ind;

	u8 endpoint_desc_ind_valid;

	u8 endpoint_desc_ind;

	u8 bw_change_ind_valid;

	u8 bw_change_ind;

};



/* The response to a IPA_QMI_INDICATION_REGISTER request consists only of