Commit 3f95ac32 authored by Daniel Lezcano's avatar Daniel Lezcano Committed by Daniel Lezcano
Browse files

thermal/core: Remove duplicate information when an error occurs 



The pr_err already tells it is an error, it is pointless to add the
'Error:' string in the messages. Remove them.

Cc: Alexandre Bailon <abailon@baylibre.com>
Cc: Kevin Hilman <khilman@baylibre.com>
Signed-off-by: default avatarDaniel Lezcano <daniel.lezcano@linexp.org>
Reviewed-by: default avatarLukasz Luba <lukasz.luba@arm.com>
Link: https://lore.kernel.org/r/20220722200007.1839356-2-daniel.lezcano@linexp.org


Signed-off-by: default avatarDaniel Lezcano <daniel.lezcano@linaro.org>
parent 50e53291

drivers/thermal/thermal_core.c

+4 −4
Original line number Diff line number Diff line
@@ -1194,23 +1194,23 @@ thermal_zone_device_register(const char *type, int trips, int mask, 
	struct thermal_governor *governor;



	if (!type || strlen(type) == 0) {

		pr_err("Error: No thermal zone type defined\n");

		pr_err("No thermal zone type defined\n");

		return ERR_PTR(-EINVAL);

	}



	if (type && strlen(type) >= THERMAL_NAME_LENGTH) {

		pr_err("Error: Thermal zone name (%s) too long, should be under %d chars\n",

		pr_err("Thermal zone name (%s) too long, should be under %d chars\n",

		       type, THERMAL_NAME_LENGTH);

		return ERR_PTR(-EINVAL);

	}



	if (trips > THERMAL_MAX_TRIPS || trips < 0 || mask >> trips) {

		pr_err("Error: Incorrect number of thermal trips\n");

		pr_err("Incorrect number of thermal trips\n");

		return ERR_PTR(-EINVAL);

	}



	if (!ops) {

		pr_err("Error: Thermal zone device ops not defined\n");

		pr_err("Thermal zone device ops not defined\n");

		return ERR_PTR(-EINVAL);

	}